chore: enable release-as=patch for release-please to trigger patch release for all packages #1259
Conversation
…er patch release for all packages Signed-off-by: Jonathan Norris <[email protected]>
Summary of ChangesHello @jonathannorris, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a configuration change to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds release-as: "patch" to the release-please-config.json. This will force all future releases to be patch-level releases, overriding the versioning logic based on Conventional Commits. This is generally used for one-off releases and can be problematic if left in the main configuration, as it will prevent automatic minor and major version bumps. My review includes a comment on this change with a recommendation to handle one-off releases differently to preserve the semantic versioning automation.
release-please-config.json
Outdated
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "bootstrap-sha": "64eadd1b615997440ab4a246b941a24d13abd220", | |||
| "release-as": "patch", | |||
There was a problem hiding this comment.
Adding release-as: "patch" to the root of the configuration will force all future releases for all packages to be patch releases. This overrides the automatic version bumping based on Conventional Commit messages (e.g., feat: for minor, fix: for patch, BREAKING CHANGE for major).
If this is intended for a one-time patch release, this change should not be merged into the main branch. Instead, the release-as parameter should be provided directly to the release-please action or command for that specific run, which avoids permanently altering the release behavior.
Leaving this in the configuration will prevent automatic minor and major version bumps. Is this the intended long-term behavior?
jonathannorris
changed the title
Signed-off-by: Jonathan Norris <[email protected]>
Signed-off-by: Jonathan Norris <[email protected]>
2 participants
Enabling
"release-as": "patch"in therelease-please-config.jsonconfig per-package will trigger patch releases for each package, allowing us to test NPM OIDC connections with a patch release.